Skip to content

Add RISC-V support#100

Merged
tmfink merged 3 commits intocapstone-rust:masterfrom
Amanieu:riscv
Jul 12, 2021
Merged

Add RISC-V support#100
tmfink merged 3 commits intocapstone-rust:masterfrom
Amanieu:riscv

Conversation

@Amanieu
Copy link
Copy Markdown
Contributor

@Amanieu Amanieu commented Jul 3, 2021

The vendored capstone is updated to include capstone-engine/capstone#1682.

@Amanieu
Copy link
Copy Markdown
Contributor Author

Amanieu commented Jul 6, 2021

CI failure seems to be unrelated, the same error happens on master.

@tmfink
Copy link
Copy Markdown
Member

tmfink commented Jul 11, 2021

Thanks for the PR, this looks really great!

My only request is that you add some unit tests, which will increase confidence (especially when we make subsequent upgrades to the bundled capstone). I suggest convert several of the instructions from capstone-sys/capstone/tests/test_riscv.c.

As an example, take a look at capstone-rs/src/test.rs tests test_arch_mips()/test_arch_mips_detail().

@Amanieu
Copy link
Copy Markdown
Contributor Author

Amanieu commented Jul 12, 2021

@tmfink tmfink merged commit 3f40cd3 into capstone-rust:master Jul 12, 2021
@tmfink
Copy link
Copy Markdown
Member

tmfink commented Jul 12, 2021

I did add tests: https://github.com/capstone-rust/capstone-rs/pull/100/files#diff-a1c12c7efdc33c34fd3c1e0d29eec806c2444907eb898f64356208960fbae58f

Sorry--don't know how I missed that. Thanks for the contribution!

@Amanieu
Copy link
Copy Markdown
Contributor Author

Amanieu commented Jul 12, 2021

Could you publish a new version with this change?

@Amanieu
Copy link
Copy Markdown
Contributor Author

Amanieu commented Jul 13, 2021

Ping for publishing a new release.

@tmfink
Copy link
Copy Markdown
Member

tmfink commented Jul 14, 2021

I published version 0.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants