Skip to content

Conversation

@pradithya
Copy link
Member

@pradithya pradithya commented Sep 1, 2022

Add serialization and deserialization benchmark for UPI and compare against JSON.
The benchmark is performed with various payload size and is controlled via 2 parameters (n_rows and n_cols) for both request and response payload.

NOTE: the benchmark result can be seen in the test log.
Screenshot 2022-09-01 at 12 41 04 PM

@pradithya pradithya changed the title Add benchmark Add python benchmark Sep 1, 2022
@pradithya pradithya marked this pull request as ready for review September 1, 2022 04:37
@pradithya pradithya self-assigned this Sep 1, 2022
Copy link
Contributor

@leonlnj leonlnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems like proto is generally faster. The catch is that, if this is done once/same number of times as http.

Thanks!

@pradithya pradithya merged commit 7467c7b into main Sep 2, 2022
@pradithya pradithya deleted the benchmark branch September 2, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants