Skip to content

Conversation

@pradithya
Copy link
Member

@pradithya pradithya commented Sep 5, 2022

This PR add continuous benchmark validation and report publishing using https://github.com/benchmark-action/github-action-benchmark.

@pradithya pradithya marked this pull request as ready for review September 5, 2022 05:18
@pradithya pradithya self-assigned this Sep 5, 2022
Copy link
Contributor

@leonlnj leonlnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously we were benchmarking all the various python version, now we are doing 3.7 only. Is this intended? If so what is the rationale for 3.7?

Left a question, other than that LGTM! Thanks!

@pradithya pradithya mentioned this pull request Sep 5, 2022
Copy link
Collaborator

@tiopramayudi tiopramayudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall is LGTM

@pradithya
Copy link
Member Author

previously we were benchmarking all the various python version, now we are doing 3.7 only. Is this intended? If so what is the rationale for 3.7?

Yeah, turns out it slow down the CI by too much. No particular reason of choosing 3.7, we can pick any version since it compare relative performance.

@pradithya pradithya merged commit 10227b3 into main Sep 6, 2022
@pradithya pradithya deleted the continuous_bench branch September 6, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants