Skip to content

fix(treatment-service): Add pubsub message ordering flag #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deadlycoconuts merged 1 commit into from
May 2, 2025
Merged

fix(treatment-service): Add pubsub message ordering flag #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/testutils/pubsub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func CreateSubscriptions(client *pubsub.Client, ctx context.Context, topicNames
topic := client.Topic(topicName)
subscription, err := client.CreateSubscription(ctx,
subscriptionId,
pubsub.SubscriptionConfig{Topic: topic, ExpirationPolicy: time.Hour * 24})
pubsub.SubscriptionConfig{Topic: topic, ExpirationPolicy: time.Hour * 24, EnableMessageOrdering: true})
if err != nil {
return nil, err
}
Expand Down
5 changes: 3 additions & 2 deletions treatment-service/services/messagequeue/pubsub_message_queue_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ func newSubscriptionId(topic string) string {
func newPubsubSubscription(ctx context.Context, client *pubsub.Client, topic string) (*pubsub.Subscription, error) {
return client.CreateSubscription(
ctx, newSubscriptionId(topic), pubsub.SubscriptionConfig{
Topic: client.Topic(topic),
ExpirationPolicy: time.Hour * 24,
Topic: client.Topic(topic),
ExpirationPolicy: time.Hour * 24,
EnableMessageOrdering: true,
},
)
}
Expand Down
5 changes: 3 additions & 2 deletions treatment-service/testhelper/mockmanagement/server/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,9 @@ func (suite *ManagementServiceTestSuite) SetupTest() {
topic := suite.pubsubClient.Topic(TOPIC)
subscriptionId := "sub-" + uuid.NewString()
subscription, err := suite.pubsubClient.CreateSubscription(suite.ctx, subscriptionId, pubsub.SubscriptionConfig{
Topic: topic,
ExpirationPolicy: time.Hour * 24,
Topic: topic,
ExpirationPolicy: time.Hour * 24,
EnableMessageOrdering: true,
})
if err != nil {
suite.FailNow("fail to instantiate client", err.Error())
Expand Down
Loading