Merged
Conversation
…ot found cases - Changed methods in multiple classes to return Optional for identifier retrieval, improving null safety. - Updated exception handling to throw IllegalArgumentException when identifiers are not found. - Adjusted related test cases to accommodate the new Optional return type.
iFergal
reviewed
Sep 2, 2025
iFergal
reviewed
Sep 3, 2025
src/main/java/org/cardanofoundation/signify/app/coring/Operations.java
Outdated
Show resolved
Hide resolved
iFergal
approved these changes
Sep 4, 2025
yashhzd
added a commit
to yashhzd/cf-signify-java
that referenced
this pull request
Feb 14, 2026
…et() Complete the Optional refactoring started in cardano-foundation#57 for the remaining methods that still threw exceptions for not-found conditions: - SignifyClient.state() returns Optional<State> instead of throwing IllegalArgumentException on 404 - SignifyClient.connect() uses orElseThrow() for clear error messaging - Coring.KeyEvents.get() returns Optional<Object> with 404 check - Coring.Config.get() returns Optional<Object> with 404 check - TestUtils.getOrCreateClient() uses state().isEmpty() instead of try/catch flow control Closes cardano-foundation#49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #54