Feature/task remove usage of object Sith#60
Open
Sotatek-DucPhung wants to merge 5 commits intomainfrom
Open
Conversation
…ot found cases - Changed methods in multiple classes to return Optional for identifier retrieval, improving null safety. - Updated exception handling to throw IllegalArgumentException when identifiers are not found. - Adjusted related test cases to accommodate the new Optional return type.
…tiple classes - Updated CreateIdentifierArgs, RotateIdentifierArgs, and related classes to use Sith type instead of Object for isith and nsith fields. - Refactored Identifier and Tholder classes to handle Sith type for signing thresholds. - Enhanced Eventing and Controller classes to utilize Sith for improved type safety. - Added new Sith class to encapsulate signing threshold logic and provide various constructors for different threshold types. - Updated tests to validate the new Sith implementations and ensure correct functionality.
Sotatek-DucPhung
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring Summary: Removing
ObjectUsage #47🎯 Key Objectives
Objectwith specific types for better type safety🏗️ Architecture Changes
SithInterface HierarchyIntegerSith: For numeric thresholdsStringSith: For string-based thresholdsWeightedSith: For weighted threshold lists🔧 Technical Improvements
TholderClassfromObject()conversion🔄 API Updates
CreateIdentifierArgs:Object isith/nsith→Sith isith/nsithRotateIdentifierArgs:Object nsith→Sith nsithTholder.getSith():Object→SithgetOriginalSith()for backward compatibility