feat: use generated models for client.identifiers#79
Merged
Conversation
- Introduced IdentifierModelConverter for converting generated KERIA models to domain models. - Added IdentifierPayloadMapper to build request payloads for identifier endpoints. - Updated Identifier class to utilize GeneratedModelMapper for JSON parsing. - Modified IdentifierListResponse to use a list of Identifier objects instead of generic Object. - Implemented KeyStateRecordDeserializer to handle deserialization of KeyStateRecord. - Centralized Jackson configuration in GeneratedModelConfig for better management of generated models. - Updated various tests to reflect changes in identifier handling and ensure consistency.
…ds and using direct calls
…hods for consistency
…onsistency and clarity
iFergal
changed the title
…ey state" This reverts commit 28d2b6c.
Collaborator
|
@Sotatek-Patrick-Vu I reverted the last commit as this does not align with the format sent from KERIA over the wire. From your previous approach, it seems mixins aren't sufficient, and I've added a new commit which provides a fix. It's not the best fix, but it'll do for now. Opening an issue to track. |
iFergal
approved these changes
Mar 11, 2026
iFergal
deleted the
feat/enchange-identifier-handling-with-new-generated-model
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial PR to incorporate generated types from OpenAPI spec. Starting with identifier endpoints first.