Modernize CI/CD with GitHub Actions, RuboCop, and RBS types #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace legacy Travis CI and Drone CI with GitHub Actions workflows: - ruby.yml: lint, test matrix (Ruby 3.1-3.4), and RBS type validation - release.yml: automated gem publishing via OIDC trusted publisher Add modern Ruby tooling infrastructure: - RuboCop with rbs-inline annotation support - SimpleCov for test coverage reporting (93.5% line, 91% branch) - RBS inline type annotations throughout SimpleRSS class This brings simple-rss in line with cardmagic/classifier's infrastructure, enabling static type checking and standardized code style enforcement. Closes #32
Owner
Author
|
@greptile review |
Extract item tag parsing into focused methods with guard clauses: - parse_item_tag: dispatcher with early returns for tag types - parse_rel_tag: handles link+alternate style tags - parse_attr_tag: handles media:content#url style tags - parse_simple_tag: handles standard tags Extract clean_content branching into: - DATE_TAGS/STRIP_HTML_TAGS constants for clarity - parse_date: Time parsing with fallback - extract_href: href attribute extraction Eliminates 3-level nesting in favor of flat, readable code.
cardmagic
force-pushed
the
ci-modernization
branch
from
49c8d91 to
d207100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #32