Skip to content
This repository was archived by the owner on Oct 8, 2025. It is now read-only.

Conversation

@carnisj
Copy link
Owner

@carnisj carnisj commented May 31, 2022

Now the log file will be created in save_dir if this parameter is defined, otherwise in root_folder. This will allow the user to avoid permission issues in root_folder.

Modify the saturation threshold of the Eiger2M detector from 1e6 to 1e7 photons.

Fixes #261

  • Bug fix (non-breaking change which fixes an issue)

Checks:

  • I have added unit tests
  • I updated the documentation
  • I have run doit and all tasks have passed

@carnisj carnisj requested a review from mirichard-S May 31, 2022 20:19
@carnisj carnisj marked this pull request as draft June 1, 2022 05:54
@carnisj carnisj marked this pull request as ready for review June 1, 2022 07:18
@carnisj carnisj requested a review from ccechatelier June 1, 2022 07:20
@ccechatelier
Copy link
Collaborator

Sounds good to me !

@ccechatelier ccechatelier merged commit 4ea4d42 into main Jun 2, 2022
@carnisj carnisj deleted the log_dir branch June 3, 2022 07:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Trying to save a log file in the root folder

3 participants