Restructure software architecture section to demonstrate refactoring and paradaigms#234
Merged
anenadic merged 80 commits intocarpentries-incubator:rework-software-architecture-sectionfrom Dec 12, 2023
Conversation
The top sections are filled out to give an idea of content
This section outlines the key ideas for the rest of the episode.
This relates more to the descriptions of good code, so we might as well have this discussion before introducing new concepts
The section ends with revisiting this list, so explicitly request people keep hold of it. Add some glue text to make the list flow better
Is more common and essentially the same as MVVM.
Makes the callout formatting work better
This matches up with the variable names in the original code, making the refactoring more obvious
This isn't really a solution, and I think just muddies the meaning of the section
bielsnohr
requested changes
Nov 1, 2023
Collaborator
bielsnohr
left a comment
There was a problem hiding this comment.
Please change episode titles to respect title case used for all other episodes in course
Co-authored-by: Matthew <matthew.bluteau@gmail.com>
Adding in the four lines for the "full data analysis" shifts these errors down by four lines.
bielsnohr
approved these changes
Nov 22, 2023
Collaborator
bielsnohr
left a comment
There was a problem hiding this comment.
Thanks for the minor fixes. All good from my end. Passing on to other maintainers.
douglowe
reviewed
Dec 11, 2023
| - How to improve existing code to be more readable, maintainable and testable. | ||
| - Consider different strategies for writing well designed code, including | ||
| using **pure functions**, **classes** and **abstractions**. | ||
| - How to create, asses and improve software design. |
Collaborator
There was a problem hiding this comment.
'assess' rather than 'asses'?
Collaborator
|
Merging to a local branch from Thomas's repo for easier review as Thomas's time on this project ended and then will reopen a new PR. |
32ba1a1
into
carpentries-incubator:rework-software-architecture-section
Collaborator
The questions help learners understand what to expect from an episode/lesson as they might not yet understand the learning objectives. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-write of section 3, to address the #227. The aim is to focus on refactoring existing code, and demonstrate the principles of OOP, functional etc through examples where they are useful, rather than explicitly teaching them as concepts. The hope is that the result will be quicker and easier to teach.
The changes rely on a new bit of code in the example project. This can be found here:
https://github.com/thomaskileyukaea/python-intermediate-inflammation/compare/thk/code-changes-for-architecture?expand=1
✅
Still to do for structural draft✅
Still to do for first draftStill to do for final draft
Nice to have
globinto a DataSource