Conversation
douglowe
approved these changes
Nov 21, 2023
Collaborator
douglowe
left a comment
douglowe
left a comment
There was a problem hiding this comment.
Changes look sensible to me.
| > which Python module will be invoked (the one that came with your environment's Python interpreter vs. | ||
| > some other version you may have on your system). This makes it a more reliable way to set things | ||
| > up correctly and avoid issues that could prove difficult to trace and debug. | ||
| > as the name of a module and not as a single, executable program with the same name. |
Collaborator
There was a problem hiding this comment.
I've tried editing these new lines to match the source code layout Toby was working on (e.g. new sentences aren't started in the middle of lines, etc).
Collaborator
Author
There was a problem hiding this comment.
Will try to follow that in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to "python3 -m" to install pip instead of "pip3 install".
Fixes #276.