Conversation
steve-crouch
requested changes
Nov 24, 2023
Collaborator
steve-crouch
left a comment
steve-crouch
left a comment
There was a problem hiding this comment.
Generally looks good, mainly some minor corrections or suggestions, although an issue to consider with a step in reviewing that perhaps should be removed.
|
|
||
| #### Adding a review comment | ||
|
|
||
| 1. To be able to add your review to a pull request created on your course mate's repository, |
Collaborator
There was a problem hiding this comment.
I recall we discussed a callout about the general case of code review where you don't strictly need to add people to your repo to do a code review, which should be added.
Collaborator
Author
There was a problem hiding this comment.
Looks like I did a push but failed to commit before that so my latest changes did not end up in this PR - sorry @steve-crouch. It has been fixed now
Co-authored-by: Steve Crouch <s.crouch@software.ac.uk>
Co-authored-by: Steve Crouch <s.crouch@software.ac.uk>
Co-authored-by: Steve Crouch <s.crouch@software.ac.uk>
Co-authored-by: Steve Crouch <s.crouch@software.ac.uk>
Co-authored-by: Steve Crouch <s.crouch@software.ac.uk>
Co-authored-by: Steve Crouch <s.crouch@software.ac.uk>
…/python-intermediate-development into code-review-review
Co-authored-by: Steve Crouch <s.crouch@software.ac.uk>
Co-authored-by: Steve Crouch <s.crouch@software.ac.uk>
anenadic
commented
Nov 24, 2023
Co-authored-by: Steve Crouch <s.crouch@software.ac.uk>
Co-authored-by: Steve Crouch <s.crouch@software.ac.uk>
steve-crouch
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial review of code review episode and redo of screenshots.