Swap refactoring and abstractions episodes #327
Merged
anenadic merged 9 commits intorework-software-architecture-section-alexfrom Mar 27, 2024
Merged
Swap refactoring and abstractions episodes #327anenadic merged 9 commits intorework-software-architecture-section-alexfrom
anenadic merged 9 commits intorework-software-architecture-section-alexfrom
Conversation
anenadic
changed the base branch from
gh-pages
to
rework-software-architecture-section-alex
This was referenced Mar 27, 2024
steve-crouch
approved these changes
Mar 27, 2024
Collaborator
steve-crouch
left a comment
steve-crouch
left a comment
There was a problem hiding this comment.
Looks good, a few minor things, mainly clarifications:
- May want to explicitly mention the filename that should be modified in the “Use classes to abstract out data loading” exercise, just for clarity.
- The opening paragraph to the “Identify an interface between…” exercise is a little terse - how about “What would you say is the interface between the CSVDataSource class and the analyse_data() function?”
- “Testing using mock objects” - perhaps we should be using pytest and not unittest for consistency?
- “…but sometimes to make it possible to verify you are not changing the important behaviour…”
Co-authored-by: Steve Crouch <s.crouch@software.ac.uk>
Co-authored-by: Steve Crouch <s.crouch@software.ac.uk>
Co-authored-by: Steve Crouch <s.crouch@software.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #321.