Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pipelined/bevy_pbr2/src/render/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,10 @@ pub fn queue_meshes(
) {
let mesh_meta = mesh_meta.into_inner();

if view_meta.uniforms.len() == 0 {
return;
}

light_meta.shadow_view_bind_group.get_or_insert_with(|| {
render_device.create_bind_group(&BindGroupDescriptor {
entries: &[BindGroupEntry {
Expand Down
10 changes: 10 additions & 0 deletions pipelined/bevy_render2/src/render_resource/uniform_vec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ impl<T: AsStd140> UniformVec<T> {
})
}

#[inline]
pub fn len(&self) -> usize {
self.values.len()
}

#[inline]
pub fn capacity(&self) -> usize {
self.capacity
Expand Down Expand Up @@ -145,6 +150,11 @@ impl<T: AsStd140> DynamicUniformVec<T> {
self.uniform_vec.binding()
}

#[inline]
pub fn len(&self) -> usize {
self.uniform_vec.len()
}

#[inline]
pub fn capacity(&self) -> usize {
self.uniform_vec.capacity()
Expand Down
5 changes: 4 additions & 1 deletion pipelined/bevy_render2/src/renderer/render_device.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ impl RenderDevice {

/// Creates a shader module from either SPIR-V or WGSL source code.
#[inline]
pub fn create_shader_module<'a>(&self, desc: impl Into<wgpu::ShaderModuleDescriptor<'a>>) -> wgpu::ShaderModule {
pub fn create_shader_module<'a>(
&self,
desc: impl Into<wgpu::ShaderModuleDescriptor<'a>>,
) -> wgpu::ShaderModule {
self.device.create_shader_module(&desc.into())
}

Expand Down
17 changes: 16 additions & 1 deletion pipelined/bevy_sprite2/src/render/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,18 @@ use crate::Sprite;
use bevy_asset::{Assets, Handle};
use bevy_ecs::{prelude::*, system::SystemState};
use bevy_math::{Mat4, Vec2, Vec3, Vec4Swizzles};
use bevy_render2::{core_pipeline::Transparent2dPhase, mesh::{shape::Quad, Indices, Mesh, VertexAttributeValues}, render_asset::RenderAssets, render_graph::{Node, NodeRunError, RenderGraphContext}, render_phase::{Draw, DrawFunctions, Drawable, RenderPhase, TrackedRenderPass}, render_resource::*, renderer::{RenderContext, RenderDevice}, shader::Shader, texture::{BevyDefault, Image}, view::{ViewMeta, ViewUniform, ViewUniformOffset}};
use bevy_render2::{
core_pipeline::Transparent2dPhase,
mesh::{shape::Quad, Indices, Mesh, VertexAttributeValues},
render_asset::RenderAssets,
render_graph::{Node, NodeRunError, RenderGraphContext},
render_phase::{Draw, DrawFunctions, Drawable, RenderPhase, TrackedRenderPass},
render_resource::*,
renderer::{RenderContext, RenderDevice},
shader::Shader,
texture::{BevyDefault, Image},
view::{ViewMeta, ViewUniform, ViewUniformOffset},
};
use bevy_transform::components::GlobalTransform;
use bevy_utils::slab::{FrameSlabMap, FrameSlabMapKey};
use bytemuck::{Pod, Zeroable};
Expand Down Expand Up @@ -276,6 +287,10 @@ pub fn queue_sprites(
gpu_images: Res<RenderAssets<Image>>,
mut views: Query<&mut RenderPhase<Transparent2dPhase>>,
) {
if view_meta.uniforms.len() == 0 {
return;
}

// TODO: define this without needing to check every frame
sprite_meta.view_bind_group.get_or_insert_with(|| {
render_device.create_bind_group(&BindGroupDescriptor {
Expand Down