Fixed issue where transform buffer wasn't creating new bindings on resize.#7
Merged
cart merged 3 commits intocart:pipelined-renderingfrom Jul 1, 2021
Merged
Conversation
Owner
|
Yup good call. My current take for the future:
|
cart
pushed a commit
that referenced
this pull request
Jul 24, 2021
cart
pushed a commit
that referenced
this pull request
Jul 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mainly just changes transform bindings from being stored like:
to
The reason for this change is that when the
transform_uniformsgrow in prepare we need to create a new bind group in queue as we have a new uniform buffer.In the future I think we should have some sort of single item API for single bind groups like this as it felt kinda weird needing to store the
FrameSlabMapKey.