Use string-specific pretty_assertions displayer in tests#2435
Merged
casey merged 3 commits intocasey:masterfrom Oct 30, 2024
Merged
Use string-specific pretty_assertions displayer in tests#2435casey merged 3 commits intocasey:masterfrom
casey merged 3 commits intocasey:masterfrom
Conversation
Owner
|
Nice, this is much better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pretty_assertionscrate that the test harness is already using has a string-specific comparison implementation that can properly display ANSI escapes, which are pretty frequent injusttests.When running e.g.
cargo test unicode_escape_invalid_character:Before:
After:
This should help with the test conversion that needs to happen in #2426