Do not hard-code /bin/bash #693
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While /bin/bash does exist on many platforms, it's not guaranteed to be the case. One prominent example is NixOS. The portable way to invoke scripts is to use #!/usr/bin/env bash which finds the most appropriate bash binary from the user's configured PATH.
Contributor
|
This is important! On macOS Take the following from my Mac running macOS 26.1: /bin/bash --version
GNU bash, version 3.2.57(1)-release (arm64-apple-darwin25)
Copyright (C) 2007 Free Software Foundation, Inc./usr/bin/env bash --version
GNU bash, version 5.3.3(1)-release (aarch64-apple-darwin24.4.0)
Copyright (C) 2025 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.I can (and did) install a newer version myself, but |
Collaborator
|
@KevinGimbel the version of bash installed on your laptop is irrelevant to Hermit. It deliberately doesn't require any functionality more recent than the versions on Mac. |
Collaborator
|
@JamesGuthrie I'll fix that failure. |
alecthomas
reviewed
Jan 6, 2026
| version "4.4-temporary" { | ||
| on "unpack" { | ||
| run { | ||
| cmd = "/bin/ln -s ${root}/bin/make ${root}/make" |
Collaborator
There was a problem hiding this comment.
The cmd deliberately requires explicit paths so that it doesn't search the $PATH and have the wrong binary injected. This basically circumvents that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While /bin/bash does exist on many platforms, it's not guaranteed to be the case. One prominent example is NixOS. The portable way to invoke scripts is to use #!/usr/bin/env bash which finds the most appropriate bash binary from the user's configured PATH.