Skip to content

Ignore csp.withgoogle.com in link validation#544

Merged
edward3h merged 2 commits intocasid:mainfrom
utafrali:fix/issue-543-validate-external-links-sometimes-fails-
Apr 10, 2026
Merged

Ignore csp.withgoogle.com in link validation#544
edward3h merged 2 commits intocasid:mainfrom
utafrali:fix/issue-543-validate-external-links-sometimes-fails-

Conversation

@utafrali
Copy link
Copy Markdown
Contributor

@utafrali utafrali commented Apr 7, 2026

Fixes #543

The domain keeps timing out in link validation. Easier to just skip it in the ignore file.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.17%. Comparing base (ee988e8) to head (bea5551).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #544   +/-   ##
=========================================
  Coverage     91.17%   91.17%           
  Complexity     1223     1223           
=========================================
  Files            76       76           
  Lines          3185     3185           
  Branches        489      489           
=========================================
  Hits           2904     2904           
  Misses          173      173           
  Partials        108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edward3h
Copy link
Copy Markdown
Collaborator

edward3h commented Apr 7, 2026

Other domains are as "exclude" arguments in .github/workflows/validate-links.yml. Looks like this works differently?

@utafrali
Copy link
Copy Markdown
Contributor Author

utafrali commented Apr 7, 2026

Fair point - want me to add it to the exclude list instead?

@edward3h
Copy link
Copy Markdown
Collaborator

edward3h commented Apr 8, 2026

I don't know the original intention, but it would make sense to follow the existing setup.

@utafrali
Copy link
Copy Markdown
Contributor Author

utafrali commented Apr 8, 2026

Done, pushed the fix.

@edward3h
Copy link
Copy Markdown
Collaborator

edward3h commented Apr 8, 2026

Done, pushed the fix.

It doesn't look like the PR changed. Can you check?

@utafrali
Copy link
Copy Markdown
Contributor Author

utafrali commented Apr 8, 2026

Done, pushed the fix.

@utafrali
Copy link
Copy Markdown
Contributor Author

utafrali commented Apr 9, 2026

Done, pushed the fix.

@edward3h edward3h merged commit f49dd96 into casid:main Apr 10, 2026
14 checks passed
@edward3h
Copy link
Copy Markdown
Collaborator

Thank you for your contribution!

@utafrali
Copy link
Copy Markdown
Contributor Author

Thank you! Glad the contribution was useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validate-external-links sometimes fails on https://csp.withgoogle.com/docs/strict-csp.html

2 participants