NDRS-145: DeployFetcher#110
Closed
marc-casperlabs wants to merge 2 commits intocasper-network:masterfrom
Closed
Conversation
casperlabs-bors-ng bot
added a commit
that referenced
this pull request
Sep 6, 2022
3302: Merge 1.4.8 to dev r=mpapierski a=mpapierski This PR merges the 1.4.8 bugfix release into dev by cherry-picking relevant fixes from the history of the v1.4.8 release. A complete history of v1.4.8 release as compared to dev: dev...v1.4.8 Commits cherry-picked in order starting from `Clippy fixes with recent stable` (a369e37). | Message | Git SHA on v1.4.8 | Cherry-picked | | --- | --- | --- | `(Merge #115, 2022-08-14)` | b94c4f7 | merge commit | `(version bump casper-node and assembly script, 2022-08-12)` | 389dddc | 696206e | `(Merge pull request #114 from casper-network/regression-20220727-part2, 2022-08-12)` | 281061f | merge commit | `(Add changelog and docs., 2022-08-12)` | 01999db | a301241 | `(Shuffle ensure_* functions in order, 2022-08-12)` | 3677f9d | 99bfdd9 | `(Simplify checking algorithm, 2022-08-12)` | 6658738 | 5a7d1bd | `(Fix clippy issues., 2022-08-12)` | 0ee97fc | empty commit | `(Add checks to avoid panics in the gas accounting, 2022-08-11)` | 4340204 | 3881820 | `(Add regression tests for gas counter injector., 2022-08-11)` | e710b8e | 09f023a | `(Restrict access to non-declared globals., 2022-08-10)` | 7944881 | a2ca3dc | `(Regression tests for global set/get access., 2022-08-10)` | 843cf53 | 5432145 | `(Merge #113, 2022-08-03)` | 298dfaa | merge commit | `(further updates required for version bumps, 2022-08-03)` | 9129165 | 5c07b4e | `(Bumping EE, casper-node and assembly script (to keep from erroring on publish)., 2022-08-02)` | 55a413d | 6823aa6 | `(Merge pull request #110 from casper-network/regression-20220727, 2022-08-02)` | 17a39d8 | | `(Fix backwards compatibility, 2022-08-02)` | 476a236 | 1ac4e8c | `(Apply suggestions from code review, 2022-08-02)` | 7ae3f1d | 11c0f95 | `(Rewrite for clarity as `@goral09` suggested, 2022-08-01)` | 7b84dfa | 1de2f62 | `(Ensure internal gas function cannot be imported., 2022-07-29)` | 31fe6b3 | 822bea0 | `(Ensure functions max param size., 2022-07-29)` | ea0f05c | 8f2dff4 | `(Ensure module doesnt declare more than 256 globals, 2022-07-29)` | 20a667a | 496f5a8 | `(Limit the size of a br_table to 256 elements., 2022-07-29)` | 3d51997 | 83023e1 | `(Apply review comments, 2022-07-29)` | e562a5c | 5ec9af7 | `(Apply review comments, 2022-07-28)` | 223d861 | f064a36 | `(Lower the table size to 4k, 2022-07-28)` | 438f56e | 66b3e9c | `(Fix the issue by imposing a limit for table size., 2022-07-27)` | 7dc6dcb | bec2292 | `(Add regression test to trigger the issue., 2022-07-27)` | 1eafe74 | c31d448 | `(Clippy fixes with recent stable, 2022-07-27)` | a369e37 | effectively empty commit | Co-authored-by: Michał Papierski <michal@casperlabs.io> Co-authored-by: Joe Sacher <321623+sacherjj@users.noreply.github.com> Co-authored-by: Fraser Hutchison <fraser@casperlabs.io>
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
The input coin defined in the specifications is an aggregated type between two logical variants: signed and predicate. When the input is expected to behave as coin, the signature validation should seek its witness counterpart and check the signature with its fields as arguments = except for predicate and its data. When the input is expected to behave as predicate, the validation will check if the owner is the hash of the predicate. The witness id is entirely ignored. It is canonical to Rust to split these two different logical structures into different enum variants - even if we are to maintain the fuel specs canonical serialization. Closes #110
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
The input coin defined in the specifications is an aggregated type between two logical variants: signed and predicate. When the input is expected to behave as coin, the signature validation should seek its witness counterpart and check the signature with its fields as arguments = except for predicate and its data. When the input is expected to behave as predicate, the validation will check if the owner is the hash of the predicate. The witness id is entirely ignored. It is canonical to Rust to split these two different logical structures into different enum variants - even if we are to maintain the fuel specs canonical serialization. Closes #110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR I'm opening for @EdHastingsCasperLabs .