NDRS-164: fetcher optimization#135
Merged
EdHastingsCasperAssociation merged 1 commit intocasper-network:masterfrom Aug 3, 2020
Merged
Conversation
EdHastingsCasperAssociation
requested review from
Fraser999,
marc-casperlabs,
mpapierski and
sacherjj
and removed request for
Fraser999
Fraser999
approved these changes
Aug 3, 2020
afck
reviewed
Aug 3, 2020
| for responder in responders { | ||
| effects.extend(responder.respond(None).ignore()); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Should we remove the entry id at this point, if it's empty now?
sacherjj
pushed a commit
that referenced
this pull request
Feb 8, 2024
Fix allocation in `FromBytes for Vec<T>`
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the fetcher component to signal all responders with the item as soon as it becomes available from any source.
https://casperlabs.atlassian.net/browse/NDRS-164