NO-TICK: Use block height when resolving pre-state hash.#169
Merged
goral09 merged 2 commits intocasper-network:masterfrom Aug 26, 2020
Merged
NO-TICK: Use block height when resolving pre-state hash.#169goral09 merged 2 commits intocasper-network:masterfrom
goral09 merged 2 commits intocasper-network:masterfrom
Conversation
Contributor
Author
|
Tested by running 5-node network: no errors, no warnings and nodes finalized same blocks in the same order. |
afck
approved these changes
Aug 26, 2020
Contributor
afck
left a comment
afck
left a comment
There was a problem hiding this comment.
Looks good to me.
I'm still a bit confused and am wondering whether this will come back to bite us; but I don't see how. Anyway, could you add the reason why we need this to the description? (I know we talked about it yesterday, but I can't remember.)
Contributor
Author
|
First, I think it's simpler. Second, the reason for doing it is so that we can turn linear chain's |
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
sacherjj
pushed a commit
that referenced
this pull request
Oct 7, 2025
[BUG] Dynamic Gas Price Integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how the pre-state hash for the finalized block is calculated. Instead of fetching it by protoblock's hash we fetch it based on the finalized block height.