Fix feature set on casper-contract#2263
Merged
casperlabs-bors-ng[bot] merged 1 commit intocasper-network:release-1.4.1from Oct 22, 2021
Merged
Fix feature set on casper-contract#2263casperlabs-bors-ng[bot] merged 1 commit intocasper-network:release-1.4.1from
casperlabs-bors-ng[bot] merged 1 commit intocasper-network:release-1.4.1from
Conversation
darthsiroftardis
approved these changes
Oct 22, 2021
luis-casper
approved these changes
Oct 22, 2021
nilz3ro
approved these changes
Oct 22, 2021
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an accidental breaking change in the Rust features of the
casper-contractcrate, introduced in the 1.4.0 version.The previous 1.3.x behavior has been reinstated, whereby if the
stdfeature is enabled,casper-contractdoes not provide thewee-allocallocator, and instead explicitly imports the std library with its allocator.There is also a regression test added in the form of a test contract which enables the
stdfeature ofcasper-contract.Furthermore these changes were tested against the Payment Contract Example and Casper Keys Manager with their recent changes (#3 and #18 respectively) reverted.
Closes #2261.