Disable expensive LNC check.#2385
Merged
TomVasile merged 7 commits intocasper-network:release-1.4.1-altfrom Nov 30, 2021
Merged
Disable expensive LNC check.#2385TomVasile merged 7 commits intocasper-network:release-1.4.1-altfrom
TomVasile merged 7 commits intocasper-network:release-1.4.1-altfrom
Conversation
goral09
approved these changes
Nov 22, 2021
fizyk20
approved these changes
Nov 22, 2021
GuybrushX
reviewed
Nov 22, 2021
| // endorsements again. | ||
| pub(super) const TODO_ENDORSEMENT_EVIDENCE_DISABLED: bool = true; | ||
|
|
||
| // Disables checking the limited naivete criterion for endorsements. |
There was a problem hiding this comment.
Typo or what is "naivete criterion"?
There was a problem hiding this comment.
I checked the Highway protocol PDF and it should be "naivetY" I guess.
Contributor
Author
There was a problem hiding this comment.
You're right, we should make it consistent. My English dictionary has both "naivety" and "naïveté", though.
Contributor
Author
|
bors merge |
Contributor
|
Build failed: |
Contributor
Author
|
bors merge |
Contributor
|
Build failed: |
Closed
Contributor
Author
|
bors merge |
Contributor
|
Build failed: |
mpapierski
pushed a commit
to mpapierski/casper-node
that referenced
this pull request
Dec 1, 2021
20: Disable endorsements, port casper-network#2395 to release-1.4.3. r=afck a=afck This ports casper-network#2395 to release-1.4.3, i.e. disabling endorsements,including the expensive LNC check, (casper-network#2385) and in addition disabling creation and citation of endorsements. Co-authored-by: Andreas Fackler <andreas@casperlabs.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.