Do not create temporary purses during distribute#2396
Merged
casperlabs-bors-ng[bot] merged 6 commits intocasper-network:devfrom Nov 29, 2021
Merged
Do not create temporary purses during distribute#2396casperlabs-bors-ng[bot] merged 6 commits intocasper-network:devfrom
casperlabs-bors-ng[bot] merged 6 commits intocasper-network:devfrom
Conversation
darthsiroftardis
requested review from
EdHastingsCasperAssociation,
Fraser999,
goral09 and
mpapierski
darthsiroftardis
changed the title
mint_into_existing_purse
EdHastingsCasperAssociation
approved these changes
Nov 24, 2021
Collaborator
EdHastingsCasperAssociation
left a comment
EdHastingsCasperAssociation
left a comment
There was a problem hiding this comment.
see nits vis a vis comments
rafal-ch
reviewed
Nov 25, 2021
goral09
reviewed
Nov 25, 2021
goral09
reviewed
Nov 25, 2021
goral09
reviewed
Nov 25, 2021
goral09
reviewed
Nov 25, 2021
goral09
reviewed
Nov 25, 2021
| amount: U512, | ||
| existing_purse: URef, | ||
| ) -> Result<(), Error> { | ||
| if self.context.get_caller() != PublicKey::System.to_account_hash() |
Contributor
There was a problem hiding this comment.
Should we even allow for a non-system account to call mint endpoints? I don't think so.
Contributor
There was a problem hiding this comment.
I think we should address that in a separate PR too if required - this PR matches the existing functionality I believe.
goral09
reviewed
Nov 25, 2021
execution_engine_testing/tests/src/test/system_contracts/auction/distribute.rs
Show resolved
Hide resolved
goral09
reviewed
Nov 25, 2021
execution_engine_testing/tests/src/test/system_contracts/auction/distribute.rs
Show resolved
Hide resolved
mpapierski
reviewed
Nov 25, 2021
Fraser999
suggested changes
Nov 29, 2021
Fraser999
approved these changes
Nov 29, 2021
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG:
mint_into_existing_pursethat transfers newly minted token into an existing purse without having to create a temporary purseCloses #2384