Avoid passing named_keys into runtime::call_host_ methods.#2433
Merged
casperlabs-bors-ng[bot] merged 6 commits intocasper-network:devfrom Jan 12, 2022
Merged
Avoid passing named_keys into runtime::call_host_ methods.#2433casperlabs-bors-ng[bot] merged 6 commits intocasper-network:devfrom
casperlabs-bors-ng[bot] merged 6 commits intocasper-network:devfrom
Conversation
mpapierski
approved these changes
Dec 23, 2021
Collaborator
mpapierski
left a comment
mpapierski
left a comment
There was a problem hiding this comment.
LGTM but you need to fix clippy issues @nilz3ro
Fraser999
approved these changes
Jan 12, 2022
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
dwerner
pushed a commit
to dwerner/casper-node
that referenced
this pull request
Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I have removed named keys from the signatures of the following functions:
Runtime::call_host_mint()Runtime::call_host_auction()Runtime::call_host_handle_payment()