Update checksummed hex implementation to use 32 byte rather than 64 byte blake2b digests#2439
Merged
casperlabs-bors-ng[bot] merged 9 commits intocasper-network:devfrom Dec 4, 2021
Conversation
…yte blake2b digests
Fraser999
requested review from
afck,
goral09,
marc-casperlabs,
nilz3ro and
rafal-ch
afck
approved these changes
Dec 4, 2021
goral09
approved these changes
Dec 4, 2021
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the hash function used internally by the checksummed hex implementation. It is now using a 32 byte blake2b digest (as per all other usages across casper core crates) rather than the default 64 byte blake2b digest.
This is a port of #23. All commits are unmodified cherry-picks from that PR except:
dd6cd54had a merge conflict in the types changelog4509b90is a new commit as requested by @goral09 moving theblake2bfunction to a more logical moduleCloses #2418.