Skip to content

HWY-93: Add some tests for test harness elements. Fix a bug.#51

Merged
goral09 merged 13 commits intocasper-network:masterfrom
goral09:hwy-93_highway_test_instance
Jul 3, 2020
Merged

HWY-93: Add some tests for test harness elements. Fix a bug.#51
goral09 merged 13 commits intocasper-network:masterfrom
goral09:hwy-93_highway_test_instance

Conversation

@goral09
Copy link
Contributor

@goral09 goral09 commented Jul 3, 2020

No description provided.

@goral09 goral09 requested review from afck and fizyk20 July 3, 2020 07:36
@goral09 goral09 requested a review from afck July 3, 2020 08:28
Copy link
Contributor

@afck afck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I'm still a bit confused about the ordering: So the ones with the later timestamps are out put first by the queue?

@goral09
Copy link
Contributor Author

goral09 commented Jul 3, 2020

So the ones with the later timestamps are out put first by the queue?

No, they're first. Since it's a BinaryHeap it would (out)put the greatest elements first. So, for the case of QueueEntry , originally, it would first output messages with the latest timestamp. That's why I had to add .reverse(). If you look at the this test you will notice that we enqueue messages starting with the one that has the latest timestamp (Instant(10)) but we expect to first get the message with the lowest one.

@goral09 goral09 merged commit c065919 into casper-network:master Jul 3, 2020
@goral09 goral09 deleted the hwy-93_highway_test_instance branch July 3, 2020 09:39
sacherjj pushed a commit that referenced this pull request Apr 4, 2022
51: Simplify logic around attenuation code r=mpapierski a=mpapierski

Co-authored-by: Fraser Hutchison <fraser@casperlabs.io>
Co-authored-by: Ed Hastings <ed@casperlabs.io>
Co-authored-by: Karan Dhareshwar <karan@casperlabs.io>

52: GOV-154: System contract refresher backport r=mpapierski a=mpapierski

This PR backports a system contract refresher from a dev branch which will always update system contracts at a version bump, not only at a major version bump. 

This change should solve the problem at the integration network today where the `step` function couldn't execute `distribute` due to missing `mint_into_existing_purse` EntryPoint definition in mint contract metadata. 

Co-authored-by: Michał Papierski <michal@casperlabs.io>
rafal-ch pushed a commit that referenced this pull request Sep 11, 2024
rafal-ch pushed a commit that referenced this pull request Sep 11, 2024
rafal-ch pushed a commit that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants