NO-TICKET: Relax constraints on the ValidatorSecret trait#63
Closed
fizyk20 wants to merge 1 commit intocasper-network:masterfrom
Closed
NO-TICKET: Relax constraints on the ValidatorSecret trait#63fizyk20 wants to merge 1 commit intocasper-network:masterfrom
fizyk20 wants to merge 1 commit intocasper-network:masterfrom
Conversation
goral09
reviewed
Jul 9, 2020
| } | ||
|
|
||
| // `#[derive]` doesn't work if `C::ValidatorSecret` is not `Eq` | ||
| impl<C: Context> Eq for SignedWireVote<C> {} |
Contributor
There was a problem hiding this comment.
What's happening here? Is it using the PartialEq?
Contributor
Author
There was a problem hiding this comment.
Yes. Trait Eq is just a marker which says that the PartialEq implementation has some specific properties. It doesn't add any methods itself.
goral09
approved these changes
Jul 9, 2020
Contributor
Author
|
Closing in favor of #64 |
dwerner
pushed a commit
to dwerner/casper-node
that referenced
this pull request
Apr 4, 2022
63: Remove temporary restrictions on trie leaf size and number of delegators per validator r=rafal-ch a=rafal-ch This PR removes a temporary limit on the maximum size for a trie leaf and lifts the restriction on the max number of delegators per validator. Closes casper-network#2636 Co-authored-by: Rafał Chabowski <rafal@casperlabs.io>
fizyk20
pushed a commit
to fizyk20/casper-node
that referenced
this pull request
Sep 9, 2022
…ync-v2 Fast sync v2
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
* add byte_price field * fix MAX_GAS_PER_TX to apply to gas limit instead of gas price
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces a bunch of
#[derive]s on Highway structs with manual implementations so thatContext::ValidatorSecretdoesn't have to implementClone,DebugandEq. For some reason, even though these structs only contain fields of typeContext::ValidatorSecret::Signature, the derives require these traits to also be implemented onValidatorSecretitself, and we might deliberately not want to implement them for secret values.