Announce new deploys in storage#89
Merged
afck merged 8 commits intocasper-network:masterfrom Jul 16, 2020
marc-casperlabs:NDRS-165/announce-new-deploys
Merged
Announce new deploys in storage#89afck merged 8 commits intocasper-network:masterfrom marc-casperlabs:NDRS-165/announce-new-deploys
afck merged 8 commits intocasper-network:masterfrom
marc-casperlabs:NDRS-165/announce-new-deploys
Conversation
afck
approved these changes
Jul 15, 2020
Fraser999
reviewed
Jul 15, 2020
afck
reviewed
Jul 16, 2020
…encies when creating announcement
Contributor
Author
|
Only potential issue is that I think the last commit could be construed as slightly too clever. By passing in the hash and header not as seperate entities, but instead by reference of a full deploy, there is no risk of these being "out-of-sync" by accident. This requires a bit of lifetime trickery, returning a "manual" future in the effect and some "buffering" of the future in the storage component. All this is visible in f1d03c5 |
afck
approved these changes
Jul 16, 2020
Fraser999
approved these changes
Jul 16, 2020
darthsiroftardis
pushed a commit
to darthsiroftardis/casper-node
that referenced
this pull request
Nov 8, 2021
darthsiroftardis
pushed a commit
to darthsiroftardis/casper-node
that referenced
this pull request
Nov 8, 2021
darthsiroftardis
pushed a commit
to darthsiroftardis/casper-node
that referenced
this pull request
Nov 8, 2021
darthsiroftardis
pushed a commit
to darthsiroftardis/casper-node
that referenced
this pull request
Nov 8, 2021
darthsiroftardis
pushed a commit
to darthsiroftardis/casper-node
that referenced
this pull request
Nov 10, 2021
afck
added a commit
that referenced
this pull request
Nov 15, 2022
Prune orphaned and finalized rounds.
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements an announcement for new deploys whenever a new deploy is stored on the storage component. @Fraser999 please have a look to ensure that I did not miss a point where a deploy is inserted. =)
This PR does not have tests, as implementing those depends on reinventing a lot of things also in #87. We will have to add them once it is merged or rely on the higher level tests that leverage the deploy gossiper to find errors - if we are not seeing any new deploys, the issue should become apparent very quickly.