Add stored deploys to the buffer; delete them when proposing.#91
Closed
afck wants to merge 2 commits intocasper-network:masterfrom
afck:deploy_buffer_add
Closed
Add stored deploys to the buffer; delete them when proposing.#91afck wants to merge 2 commits intocasper-network:masterfrom afck:deploy_buffer_add
afck wants to merge 2 commits intocasper-network:masterfrom
afck:deploy_buffer_add
Conversation
This is a temporary workaround because processed and finalized blocks are not being tracked yet in the deploy buffer. For now it should prevent that we propose the same deploy multiple times.
Contributor
Author
|
Sorry, that was too quick, the tests failed! |
mpapierski
pushed a commit
to mpapierski/casper-node
that referenced
this pull request
Nov 30, 2021
13: skip validity checks for contract/contract-packages by name r=Fraser999 a=Fraser999 This PR changes the `DeployAcceptor` to _not_ validate contracts or contract packages when specified by name rather than hash. This avoids the situation where a deploy could be deemed valid when checked against global state at a given block, but invalid at the subsequent block's state. The change is applied regardless of whether the deploy is received from a client or a peer, since the problem is identical in both cases. Closes [casper-network#91](https://github.com/casper-network/Governance/issues/91). Co-authored-by: Fraser Hutchison <fraser@casperlabs.io>
rafal-ch
pushed a commit
to rafal-ch/casper-node
that referenced
this pull request
Oct 26, 2022
…ync-v2 Removing EraValidatorWeights from block_acceptor
afck
added a commit
that referenced
this pull request
Nov 15, 2022
91: Fix create_message. r=afck a=afck Fixes a double-signing bug that was caused by pruning. `create_message` would send messages that it didn't add to the protocol state. As a precaution, we also stop pruning signatures, and instead just filter out unnecessary ones in `handle_sync_state`. To fix the upgrade tests we configure the sync state interval to be much shorter than the block time, so that joining nodes have a chance to catch up. Closes https://github.com/casper-network/Governance/issues/329, https://github.com/casper-network/Governance/issues/242. Co-authored-by: Andreas Fackler <andreas@casperlabs.io>
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
rafal-ch
pushed a commit
that referenced
this pull request
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://casperlabs.atlassian.net/browse/NDRS-160