ParameterBuilder.SetConstant fails when using a default value of null

[jonasro]

Castle.DynamicProxy.Generators.Emitters.DefineParameters line 162 fails if one of the parameters passed in is a nullable type with a default value of null.

To reproduce change the default value in ClassWithMethodWithParameterWithDefaultValue.Method to null.

public class ClassWithMethodWithParameterWithDefaultValue
{
    public virtual void Method(int? value = null)
    {  }
}

Run test MethodParameterWithDefaultValue_DefaultValueIsSetOnProxiedMethodAsWell.

    [Test]
    public void MethodParameterWithDefaultValue_DefaultValueIsSetOnProxiedMethodAsWell()
    {
        var proxiedType = generator.CreateClassProxy<ClassWithMethodWithParameterWithDefaultValue>().GetType();

        var parameter = proxiedType.GetMethod("Method").GetParameters().Single(paramInfo => paramInfo.Name == "value");

        Assert.True(parameter.HasDefaultValue);
        Assert.AreEqual(3, parameter.DefaultValue);
    }

[kkozmic]

3.2 or 3.2.1?

[jonasro]

3.2.1. Reproduced it on master,

[kkozmic]

ok, do you want to have a stab at pull-requesting it?

i reckon it shouldn't be all that hard to fix code-wise

[jonasro]

Sure. I could do that, but I am not sure this is fixable since doing SetConstant does not seem to support setting default value null.
So unless you have another idea the fix would be not setting the value if default value is null.

[kkozmic]

Oh interesting.
I didn't realize that.

Krzysztof,
sent from my phone
On 29/10/2013 6:27 PM, "jonasro" notifications@github.com wrote:

Sure. I could do that, but I am not sure this is fixable since doing
SetConstant does not seem to support setting default value null.
So unless you have another idea the fix would be not setting the value if
default value is null.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-27285182
.

[pawelpabich]

@kkozmic what do you think about @jonasro idea? Would it work?

[kkozmic]

@pawelpabich I don't know.

@jonasro sent a pull request #36 but I haven't tried integrating it yet.
@jonasro - does it then handle the scenario?

Now that I think about it - knowing how the default value works, being at compile time, with DP working at runtime, if the value is not there, it should still work.

I'll give it a go and see later this week.

[pawelpabich]

Great

[pawelpabich]

Thanks a lot. How often do you release new versions on nuget ?

[kkozmic]

Not terribly often but since this is a somewhat critical fix to an issue introduced in the last release I guess we'll do a release either today or next week

[pawelpabich]

Awesome :)