Release 4.3.1

[jonorossi]

@zvirja would like the fix for #369 released.

I was hoping we'd get as repro for #371 so we can fix that defect before making a bugfix release.

@castleproject/committers your input?

[stakx]

@jonorossi - I think it would be good to wait a couple more days, hoping to get a further response in #371. If default value reproduction really causes problems (again), I'd like to fix it asap.

Update: I've found a way to provoke the reported error (#371 (comment)), although I can't be sure at this point whether it's the same cause or a different one. Either way, I'll prepare a fix for what I've found, and if we don't hear back from @zplan within a few days, there's still some chance that his issue might be fixed.

Maybe we should point @zvirja to our appveyor nuget’s for ci-builds while waiting.

I am commuting right now will fish out a link when I get into the office.

[zvirja]

@Fir3pho3nixx Thanks a lot. Unfortunately, that will not work, as I don't want to change our CI for that single case. Rather, I'm fine waiting for a couple of days before @zplan provides the scenario.

[stakx]

I just got feedback from him over at Moq, seems I'm onto the right problem. I should have a fix ready today or tomorrow.

[zvirja]

@jonorossi Are we ready to proceed now? 😊

[jonorossi]

@stakx do we need to update the changelog for your changes in bcba394?

Compare: v4.3.0...master

We can make another release if the BadImageFormatException problem is fixed.

[stakx]

@jonorossi - I've just submitted #388 (changelog entry) if you want to document #383 (fix for possible concurrency issue). Unfortunately, that PR didn't fix all of #193 (BadImageFormatException issue), though it might have resolved the NullReferenceException observed there. Hard to tell at this point. Either way, #193 is likely to remain open for another while, please don't schedule its resolution for 4.3.1.

[jonorossi]

@stakx no problem, don't worry I'm following along with that issue even though letting you guys work it out.

[jonorossi]

• Tagged v4.3.1
• Confirmed successfully pushed to nuget.org
• Tweeted

Windsor upgrade imminent. :)