Interceptor calling async method before invocation.Proceed()

[naazz]

Hi,

I am using a framework called Aspnetboilerplate that also use Castle.Core.

Im trying to create two interceptor that call an async method before invocation.Proceed(). Could not make it work. Everything explained on their repository please refer to aspnetboilerplate/aspnetboilerplate#4401
I made a sample reproducing the problem.

Is it possible? Any guidance on how to do that?

Thank you for any further help.

[naazz]

Seems to be solved by https://github.com/castleproject/Core/pull/428. Ill closed this issue after confirmation.

[stakx]

Hi @naazz. I have only been able to glance over the code you linked to, since it's quite a lot of code. However, it appears that you are experiencing the Proceed-after-await malfunction. This part of your code might be affected by it:

if (method.ReturnType == typeof(Task))
{
    returnValue = InternalAsyncHelper.AwaitTaskWithFinally(
        (Task)returnValue,
        ex =>
        {
            invocation.Proceed();
        });
}
else //Task<TResult>
{
    returnValue = InternalAsyncHelper.CallAwaitTaskWithFinallyAndGetResult(
        method.ReturnType.GenericTypeArguments[0],
        returnValue,
        ex =>
        {
            invocation.Proceed();
        });
}

Today (coincidence!), we've merged PR #439 which solves that very same problem. In the next Castle.Core release, there will be a new method IInvocation.CaptureProceedInfo(). We've also added some new documentation about async interception which explains why & how to use that new method.

I suggest that you build your project against a local version of Castle.Core's current master to see whether using IInvocation.CaptureProceedInfo() as suggested in the docs resolves the issue you're having.

+var proceed = invocation.CaptureProceedInfo();  // call before the first `await`
 returnValue = InternalAsyncHelper.AwaitTaskWithFinally(
     (Task)returnValue,
     ex =>
     {
-        invocation.Proceed();
+        proceed.Invoke();
     });

[naazz]

Amen! Thx you i will close this issue and reopen it if needed!
Any idea for when the next realease is planned?

[stakx]

@naazz, I don't know for sure, but @jonorossi usually gets things ready for a new release when enough people are asking for it. :-) We're currently in the process of finalising another few PRs, I would assume that we'd then be ready for 4.4.0 (milestone).

[xlievo]

@stakx

@naazz, I don't know for sure, but @jonorossi usually gets things ready for a new release when enough people are asking for it. :-) We're currently in the process of finalising another few PRs, I would assume that we'd then be ready for 4.4.0 (milestone).

I've reconstructed my code in advance through https://ci.appveyor.com/nuget/core-0mhe40ifodk8 to get 0.0.534 version. So far, all the unit tests have passed.
This new approach makes very little change to API and expects formal 4.4.0.
Thank you!

[stakx]

I'll close this issue as it is very likely a solved problem (see above). If you think that's a mistake, please post a brief repro code example so we can reopen.