Dynamicproxy defaultvalue issue

[hikalkan]

Hi,

I've a simple class:

public class MyClass
{
    public virtual void MyMethod(string str = null)
    {
        Console.WriteLine(str);
    }
}

When I check

typeof(MyClass).GetMethod("MyMethod").GetParameters()[0].DefaultValue

it's null (as expected). But if I create a dynamicproxy

var gen = new ProxyGenerator(new DefaultProxyBuilder());
var proxy = gen.CreateClassProxy<MyClass>();

Then I check

proxy.GetType().GetMethod("MyMethod").GetParameters()[0].DefaultValue

It is not null, it is System.Reflection.Missing

This causes a problem when I proxy an ASP.NET MVC Controller with a method which has a default parameter as null such which is defined as:

public virtual ActionResult Login(string returnUrl = "/", string loginMessage = null)

I use proxy since I want to intercept the method call.

Is this a bug or known situation.

[hikalkan]

Maybe, it's because of this lines:

#if DOTNET45
            if (parameter.HasDefaultValue && parameter.DefaultValue != null)
            {
                parameterBuilder.SetConstant(parameter.DefaultValue);
            }
#endif

in MethodEmitrer class, DefineParameters method, line 159. Maybe, it's not necessary to check if DefaultValue is null. Also, why just .Net 4.5? .Net 4.0 also supports default values.

[kkozmic]

see #35

[hikalkan]

Thanks for reply. I use "Castle.Core 3.2.2 for .NETFramework v4.5" and it still has the issue. Did not it released yet?

[kkozmic]

Does the closing mean you did get it working with v3.2.2?

[stromsky]

@hikalkan how did you solve this problem? I am experiencing the same behavior while using Castle Core 3.3.3.58.

[hikalkan]

I had made default value "" (empty string) instead of null. I'm not sure if it works now, since it was a long time ago.

[stromsky]

Splendid. Works like a charm. Thanks for turbo fast response.