Fix for optional, nullable enum method parameters #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @balefrost.
Two unit tests failed on Mono. The unit test that was ignored with "Expected: False But was: True" as the reason is still working different on Mono, and now that the default value setting code is gone the other unit test that threw on Mono now does the same. Can you restore the ignores for both tests with the expected false but true reason. Thanks. |
This change actually completely removes the codepath that would set the default parameters for methods on the proxy implementation class. That codepath was .NET 4.5 only, but it seems that System.Reflection.Emit.ParameterBuilder doesn't handle this case particularly well.
Contributor
Author
|
Sorry for the delay; I've been a bit busy. I put the |
jonorossi
added a commit
that referenced
this pull request
Mar 22, 2016
Fix for optional, nullable enum method parameters
Member
|
Thanks |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141
I only have VS2015 on my computer, and I ran into a few difficulties:
C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.1 Tools\x64toPeVerifyProbingPathsto avoid test failures.<userSettings>element from app.config completely; instead, it inlines that value into theSettings.settingsandSettings.Designer.csfiles (duplicated in both places). I'm not sure how user settings were handled in previous versions of Visual Studio, but I guess it now wants to bake the default values into the DLLs.SL40orSL50configurations from Visual Studio, either inCastle.Core.slnorCastle.Core-SL.sln. Was able to build and run tests from the command-line. Didn't investigate this too much, but I'm guessing that the command-line build does things slightly differently from the VS build.