Skip to content

Conversation

@tangdf
Copy link
Contributor

@tangdf tangdf commented May 14, 2018

KeyValuePair<Key, Value> not implemented interface IEquatable<>.

@jonorossi
Copy link
Member

Thanks @tangdf, good find, that should improve the performance of that cache lookup quite a bit. If we didn't support .NET 3.5 we could have also used a tuple.

@jonorossi jonorossi changed the title Replace KeyValuePair<MethodInfo, Type> to custom struct Improve performance of InvocationHelper cache lookups May 14, 2018
@jonorossi jonorossi merged commit d848e4d into castleproject:master May 14, 2018
@jonorossi
Copy link
Member

Merged. I've updated the changelog.

@jonorossi jonorossi added this to the vNext milestone May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants