Skip to content

Fix build error NETSDK1061 #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stakx merged 1 commit into from
Jul 13, 2019
Merged

Fix build error NETSDK1061 #451

stakx merged 1 commit into from
Jul 13, 2019

Conversation

@stakx
Copy link
Member

@stakx stakx commented Jul 13, 2019

While working on #450, I noticed that the build scripts produce a new kind of error. For example, this AppVeyor build failed with:

NETSDK1061: The project was restored using Microsoft.NETCore.App version 1.1.12, but with current settings, version 1.1.10 would be used instead. To resolve this issue, make sure the same settings are used for restore and for subsequent operations such as build or publish. Typically this issue can occur if the RuntimeIdentifier property is set during build or publish but not during restore. For more information, see https://aka.ms/dotnet-runtime-patch-selection.

Removing explicit <RuntimeIdentifier>s from the test project files appears to resolve this.

@stakx stakx force-pushed the build branch 2 times, most recently from d932e61 to 404d20d Compare July 13, 2019 16:28
@stakx stakx changed the title Fix build error Fix build error NETSDK1061 & remove build warning Jul 13, 2019
@stakx
Remove <RuntimeIdentifier> from test projects
c8c8d73 
This was apparently used as a hack to force the `dotnet` CLI to create
an EXE file without actually publishing the project.

Unfortunately, it now causes the build to fail with a NETSDK1061 error
because it leads to different versions of the .NET SDK being used for
package restore & build.

Let's instead just use `dotnet` to run the test projects' DLLs, as we
are already doing in the Linux build script.
@stakx stakx changed the title Fix build error NETSDK1061 & remove build warning Fix build error NETSDK1061 Jul 13, 2019
@stakx stakx merged commit fbb1e97 into castleproject:master Jul 13, 2019
@stakx stakx deleted the build branch July 13, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@stakx