Skip to content

feat: add severity none to cvss calculator box#142

Merged
caverav merged 2 commits intodevelopmentfrom
hotifx/cwe-severity-none
Oct 13, 2024
Merged

feat: add severity none to cvss calculator box#142
caverav merged 2 commits intodevelopmentfrom
hotifx/cwe-severity-none

Conversation

@iTzGooDLife
Copy link
Copy Markdown
Collaborator

@iTzGooDLife iTzGooDLife commented Oct 13, 2024 •
edited by coderabbitai Bot
Loading

Descripción

Se agrega la severidad informativa en el cvss calculator (severidad 0). Actualmente afecta al editar y añadir vulnerabilidades..

Motivación y Contexto

No hay un ticket sobre eso, pero es un problema actual.

¿Cómo ha sido probado?

Al editar y añadir vulnerabilidades se calcula algo con severidad 0, como se ve en la imagen adjunta:

Capturas de pantalla (si es apropiado):

image

Tipos de cambios

  • Bugfix (cambio que no interrumpe el funcionamiento y que soluciona un problema)
  • New feature (cambio que no interrumpe el funcionamiento y que añade funcionalidad)
  • Breaking change (corrección o funcionalidad que podría causar que la funcionalidad existente cambie)

Lista de verificación:

  • Mi código sigue el estilo de código de este proyecto.
  • Mi cambio requiere una modificación en la documentación.
  • He actualizado la documentación en consecuencia.
  • Requiere nuevos tests.

Summary by CodeRabbit

  • Nuevas Funciones
    • Se añadió una lógica condicional en el componente ScoreBox para manejar el caso cuando la puntuación es 0 y isComplete es verdadero, mostrando un fondo verde y la traducción para 'ninguno'.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 13, 2024 •
edited
Loading

📝 Walkthrough
📝 Walkthrough

Walkthrough

Los cambios en el componente ScoreBox implican la adición de una nueva rama condicional que maneja un caso específico cuando el score es igual a 0 y isComplete es verdadero. En este caso, el rating se establece en la traducción para 'none', y el bgColor se actualiza a un color verde específico (bg-[#53AA33]). Esta modificación altera el flujo de control al introducir una verificación adicional del valor del score, afectando así la representación del componente según el valor del score y el estado de completitud.

Changes

Archivo Resumen de cambios
frontend/src/routes/vulnerabilities/components/scoreBox.tsx Se agregó una nueva rama condicional para manejar el caso cuando score es 0 y isComplete es verdadero, ajustando el rating y el bgColor.

Suggested reviewers

  • caverav

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@caverav
Copy link
Copy Markdown
Owner

caverav commented Oct 13, 2024

Creo que el None lo deberíamos dejar con el mismo color que los informativos (#00A8FF)

coderabbitai[bot]
coderabbitai Bot reviewed Oct 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 6198ec3 and 2a2decf.

📒 Files selected for processing (1)
  • frontend/src/routes/vulnerabilities/components/scoreBox.tsx (1 hunks)
🧰 Additional context used

Comment thread frontend/src/routes/vulnerabilities/components/scoreBox.tsx
@iTzGooDLife
Copy link
Copy Markdown
Collaborator Author

iTzGooDLife commented Oct 13, 2024

Creo que el None lo deberíamos dejar con el mismo color que los informativos (#00A8FF)

Saqué el hex desde https://www.first.org/cvss/calculator/3.1#CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:N . De donde sacaste ese color?:0

@caverav
Copy link
Copy Markdown
Owner

caverav commented Oct 13, 2024

Creo que el None lo deberíamos dejar con el mismo color que los informativos (#00A8FF)

Saqué el hex desde https://www.first.org/cvss/calculator/3.1#CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:N . De donde sacaste ese color?:0

De lo que hemos estado ocupando en el dashboard, si prefieren ocupar ese está bien, pero tendré que cambiarlo en el dashboard, no tengo problema con eso btw, pero hay que acordarlo

@iTzGooDLife
Copy link
Copy Markdown
Collaborator Author

iTzGooDLife commented Oct 13, 2024

Creo que el None lo deberíamos dejar con el mismo color que los informativos (#00A8FF)

Saqué el hex desde https://www.first.org/cvss/calculator/3.1#CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:N . De donde sacaste ese color?:0

De lo que hemos estado ocupando en el dashboard, si prefieren ocupar ese está bien, pero tendré que cambiarlo en el dashboard, no tengo problema con eso btw, pero hay que acordarlo

Ahh, entiendo, considero que se debería usar este color por lo mencionado arriba, asi que pido modificar el color en el dashboard porfas.

coderabbitai[bot]
coderabbitai Bot reviewed Oct 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 2a2decf and 4ce8877.

📒 Files selected for processing (1)
  • frontend/src/routes/vulnerabilities/components/scoreBox.tsx (1 hunks)
🧰 Additional context used

Comment thread frontend/src/routes/vulnerabilities/components/scoreBox.tsx
@caverav caverav merged commit 4f836ed into development Oct 13, 2024
@caverav caverav deleted the hotifx/cwe-severity-none branch October 13, 2024 02:36
This was referenced Oct 13, 2024
Merged
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Oct 29, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@caverav caverav caverav approved these changes

@Icksir Icksir Awaiting requested review from Icksir

@sealra sealra Awaiting requested review from sealra

@jllanosg jllanosg Awaiting requested review from jllanosg

@massi-ponce massi-ponce Awaiting requested review from massi-ponce

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iTzGooDLife @caverav