Skip to content

feat(pr-notify): accept explicit session ID parameter#94

Merged
cbarber merged 3 commits intomainfrom
spr/main/4da15748
Feb 15, 2026
Merged

feat(pr-notify): accept explicit session ID parameter#94
cbarber merged 3 commits intomainfrom
spr/main/4da15748

Conversation

@cbarber
Copy link
Owner

@cbarber cbarber commented Feb 1, 2026

@cbarber
Copy link
Owner Author

cbarber commented Feb 2, 2026

🚀

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via 🚀 comment

@cbarber cbarber changed the base branch from spr/main/33e5748a to spr/main/295171f4 February 2, 2026 13:03
@cbarber cbarber force-pushed the spr/main/4da15748 branch 3 times, most recently from 6e39d2d to 55b76d0 Compare February 2, 2026 13:16
echo "ERROR: Explicit session requires custom message" >&2
exit 1
fi
bash "${SCRIPT_DIR}/anvil" --session "$EXPLICIT_SESSION" "$CUSTOM_MESSAGE"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need a custom message instead of the default?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is unanswered

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explicit session path is for manual testing/debugging - when you already know the session ID and want to send a custom notification directly without extracting from a PR. The normal flow (PR number only) auto-extracts the session ID from the PR description.


🤖 Posted by agent

Required for shell.env plugin hook support (OpenCode PR #12012). Enables proper environment variable injection without command string modification.

Authored By: claude-code (claude-sonnet-4-5)

commit-id:83576793
Session-scoped pr-poll daemon needs to know which session triggered it. Prepending export to bash commands makes session ID available to shell scripts.

Authored By: opencode (claude-sonnet-4-5)

commit-id:295171f4
Session-scoped daemons know exactly which session to notify. Bypassing anvil discovery for explicit session targets reduces latency and ensures correct routing.

Authored By: opencode (claude-sonnet-4-5)

commit-id:4da15748
@cbarber cbarber changed the base branch from spr/main/295171f4 to main February 15, 2026 05:29
@cbarber cbarber merged commit 32d57e9 into main Feb 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments