CUDA 10 Compile Fix and More Debug Information#1
Merged
cbassa merged 4 commits intocbassa:masterfrom Sep 22, 2024
Merged
Conversation
…and now require the length to be a size_t or will raise a CUDA error at runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Cees,
Here's a part of the changes I mentioned. These are the simpler ones that
Fix compiling on CUDA 10 (the extra (size_t) binds in the cudaMalloc calls seem to be required now)
Change the cuFFT call order to follow the best practise suggestion to plan FFT operations before allocating the relevant memory on the GPU (see https://docs.nvidia.com/cuda/pdf/CUFFT_Library.pdf section 2.2.1)
Add two new debug statements, when passed an incorrect argument and when we reach the end of the input voltage files
Cheers