test_unusual_inputs #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test whether function generates matrices when inputs are `incorrect`.
added `nargin ==`
test_unusual_input
Outdated
Owner
There was a problem hiding this comment.
Just for testing: some (pedantic) people will not like these two blank lines :-)
Owner
There was a problem hiding this comment.
careful: does "isinteger" do what you think it does?
|
reasonable input test case 👍 |
Owner
|
Thanks @geewhy123. I like this idea a lot but can't merge yet as it doesn't meet the specification (see the bit about "plots" and "verbose", which should be the inputs not How about taking one particular case, e.g., that Very specific tests are nice too: if we change the code and the test fails, we know exactly what is wrong... |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.