Skip to content

chore: refactor OutputContainer to remove extra translation logic #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cmdsreedev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: refactor OutputContainer to remove extra translation logic #2013

cmdsreedev wants to merge 1 commit into from

Conversation

@cmdsreedev
Copy link

@cmdsreedev cmdsreedev commented Sep 16, 2025

Why

  • Removed extra translations performed in getDerivedStateFromProps because the output props already have translated strings.
  • verified by changing language and adding labels to output

Closes #1889

@martinbedouret martinbedouret added this to the 1.39.0 milestone Nov 13, 2025
@magush27 magush27 requested a review from tomivm December 4, 2025 17:12
@tomivm
Copy link
Collaborator

tomivm commented Dec 17, 2025 •
edited
Loading

Hi!! it's looks like it is okey.
it simplify the extra logic of translations.
I am a bit afraid of lost the the translation when user change the language. I think any user use that to translate output ⚖️
I was thinking in add a feature to translate with AI. The most difficult part is users that have a TTS that is not multilingual.
Now @RodriSanchez1 is working hard in improve our TTS features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomivm tomivm Awaiting requested review from tomivm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

Consider remove the translation logic from the Output.container

4 participants

@cmdsreedev @tomivm @martinbedouret @magush27