Fix redirect behavior in AuthScreen when closing WelcomeScreen (Fixes #1949) #2077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect redirect behavior in the AuthScreen component.
Previously, closing the WelcomeScreen component without a prior navigation history caused the app to navigate to /, which resulted in a broken or blank experience.
Root Cause:
The logic inside onClose attempted:
For users entering the app directly (no prior push state), history.push('/') sent them to the base route, which does not render the board UI.
To fix this, the fallback routes was redone and routing logic was changed to accomodate for this fix.
Unit tests were also added to AuthScreen.component.test.js to cover:
- Redirecting with a populated history stack
- Redirecting without a history stack (new behavior)
- Verifying that /board/root is the fallback route
- Ensuring no regression in existing render behavior