-
-
Notifications
You must be signed in to change notification settings - Fork 259
Fix Cbuilder board import handling and improve subscription alerts #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cbuilder board import handling and improve subscription alerts #2086
Conversation
…emove redundant showPremiumRequired logic
…dal conditionally
…and simplify lock handling logic
…dialog text logic
RodriSanchez1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Please make the requested changes!
The uploaded solution is not working, it throw an error when the subscription modal is opened. I need you to test your PRs before requesting the review 😅
…d into fix/cbuilder-board-import
Thanks! Sorry, it seems I've tested with cached stuff because I didn't see the error. Solved all in the new commits. |
RodriSanchez1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Improve premium feature handling for locked boards, specifically addressing CBuilder board import functionality with enhanced subscription prompts and modal management.
Changes
PremiumFeaturecomponent rendering to better support CBuilder boardsshowPremiumRequiredaction handler for lock icon clicksSubscriptionProvider(actions, reducer, container)showPremiumRequiredlogicisUnlockMessageflag for context-specific dialogsPremiumRequiredModal