Skip to content

Conversation

@xavierleune
Copy link
Contributor

@xavierleune xavierleune commented Mar 13, 2025

  • Feature: Allow complex types to be handled by symfony/serializer if available
  • Feature: Leverage dependency injection for Serializers
  • Fix: Profiler tab was broken in some case
  • Enhancement: Better looking profiling tab

"symfony/expression-language": "^6.3 || ^7.2",
"symfony/serializer": "^6.0 || ^7.0",
"symfony/security-bundle": "^6.0 || ^7.0",
"symfony/security-core": "^6.0 || ^7.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun story: security-bundle@6.0 requires security-core ^5.4 | ^6.0 ; tests were perfectly fine when I added the User provider, even with lowest deps.
But it should not have been this way: the interface for the UserProvider was different in security-core 5.4 (loadByUsername became loadByIdentifier in 6.0). Tests were green even with security-core 5.4 ; but not anymore. So we lock the core at 6.0 minimum to avoid that.

Copy link
Contributor

@vgreb vgreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work !

@xavierleune
Copy link
Contributor Author

@vgreb I changed requirements for ting at 3.11.0, tests will pass after the release of ting

@vgreb vgreb merged commit 3d33c39 into ccmbenchmark:master Mar 14, 2025
8 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants