-
Notifications
You must be signed in to change notification settings - Fork 1
Reorganize downscaling workflow & generate design points for herbaceous crops #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… herbaceous crops
…ng on that in a separate branch
|
|
||
| #' ## Load Site Environmental Data Covariates | ||
| #' | ||
| #' Environmental data was pre-processed in the previous workflow 00-prepare.qmd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prepare.qmd no longer exists
Co-authored-by: Chris Black <chris@ckblack.org>
…ts from write_ens_outputs
…onditional subsetting for speed
…by renaming ensemble --> parameter
dlebauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some requested changes, defered most to next iteration - enumerated in ccmmf/organization#145
…into update_site_selection
Great points. I will keep workflow documentation (how) and results (what) focused on the current state and then add a CHANGELOG.md + release-notes so we can track what’s new across phases. Phase 2b will compare herbaceous vs woody. Also, I reconciled design_points.csv in 1cb2f61 |
| ### Configuration | ||
|
|
||
| Workflow settings are configured in `000-config.R`, except that the CCMMF_DIR is set in `.Renviron`. | ||
| <!-- TODO: check why CCMMF_DIR is handled separately; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that you necessarily want a third option, but in the workflows repo I've converged on passing all configuration variables as command-line arguments with defaults set via {optparse}. It's verbose but highly discoverable, allows overrides for any one step if needed, and forced me to actually write the help strings for everything.
infotroph
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see one missing comment char that'll be an error until fixed, otherwise 👍
Co-authored-by: Chris Black <chris@ckblack.org>
This PR does continues to update and reorganize the downscaling workflow while also generating design points for herbaceous crops.
Apologies that it didn't seem practical to separate these steps into separate PRs at the time.
Key Changes
data_raw/anchor_sites.csv-->data_raw/anchor_site_locations.csvanddata/anchor_sites_ids.csv-->anchor_sites.csvas recommended in 1b downscaling workflow workflows#2Review Request
Please review for correctness. Feedback on this reorganization is welcome, where possible I would prefer to address these in subsequent PRs rather than holding this one up.
Compiled report for review: downscaling_results.zip