Combat log "formatting"

[ccshiro]

Combat logging of events is not always blizzlike.

This needs more research, namely:

1. Errors in the combat log need to be identified.
2. Proper workings for said error need to be researched.

If you know of any error, and how it should work, please respond to this issue.

[YourNewfriend]

http://wowwiki.wikia.com/API_COMBAT_LOG_EVENT?oldid=2046224 (edited in wotlk) and http://forums.wowace.com/showthread.php?t=10661

Could be useful.

[hedgefund]

When the Warrior's Sword Specialization triggers, the order of events in the combat log is reversed; instead of showing something like:

Your Hamstring hits PoorSoul for 40. <- this triggered  the extra attack
You gain 1 extra attack through Sword Specialization.
You crit PoorSoul for 1326. <- the extra attack

It instead shows this:

Your Hamstring hits PoorSoul for 40. <- this triggered  the extra attack
You crit PoorSoul for 1326. <- the extra attack
You gain 1 extra attack through Sword Specialization. <- ???

[hedgefund]

When Windfury Totem triggers an extra attack, the combat log should say something to the likes of:

You hit PoorSoul for 623. <-- this triggers Windfury totem
You gain 1 extra attack through Windfury Totem.
You gain Windfury Attack. <- this is the temporary buff that grants you the extra attack power
You crit PoorSoul for 1530. <- the actual extra attack
Windfury Attack fades from you.

Instead, it says this:

You hit PoorSoul for 623. <-- this triggers Windfury totem
You crit PoorSoul for 1530. <- the actual extra attack
Windfury Attack is refresh on you.