forked from urwen/temper
-
Notifications
You must be signed in to change notification settings - Fork 34
Open
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Description
I have been looking at the code and noticed that its was using select is an odd way.
The oddity is that the fd is not set O_NONBLOCK.
The end result of using O_NONBLOCK is that the code will report the temperatures as soon the sensor reports them.
Takes 0.386s vs the old code taking 0.558s. Tested with a TEMPer2.
If you are interest in my refactors let me know and I will raise a PR.
My refactor is in barry-scott@772d8c0.
Testers Needed
- TEMPer 0c45:7401 TEMPerF1.4 I Metal
- TEMPer 413d:2107 TEMPerGold_V3.1 I Metal
- TEMPerHUM 413d:2107 TEMPerX_V3.1 I I White plastic
- TEMPer2 413d:2107 TEMPerX_V3.3 I,E White plastic
- TEMPer2 1a86:e025 TEMPer2_V3.7 I,E White plastic with red button
- TEMPer1F 413d:2107 TEMPerX_V3.3 E White plastic
- TEMPerX232 1a86:5523 TEMPerX232_V2.0 I,E I White plastic
- TEMPer1V1.1 0c45:7401 TEMPer1F1.1Per1F E Metal
Tests Passing
- TEMPer 0c45:7401 TEMPerF1.4 I Metal
- TEMPer 413d:2107 TEMPerGold_V3.1 I Metal
- TEMPerHUM 413d:2107 TEMPerX_V3.1 I I White plastic
- TEMPer2 413d:2107 TEMPerX_V3.3 I,E White plastic
- TEMPer2 1a86:e025 TEMPer2_V3.7 I,E White plastic with red button
- TEMPer1F 413d:2107 TEMPerX_V3.3 E White plastic
- TEMPerX232 1a86:5523 TEMPerX232_V2.0 I,E I White plastic
- TEMPer1V1.1 0c45:7401 TEMPer1F1.1Per1F E Metal
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed