Wrong TypeScript return type for futuresCancelAll

[vitaly-t]

Whenever I call futuresCancelAll, I always get this:

{ code: 200, msg: 'The operation of cancel all open order is done.' }

...which corresponds to type FuturesCancelAllOpenOrder, but never to the expected array FuturesCancelAllOpenOrder[].

And somehow it doesn't even matter when the operation cancels multiple orders, it is always the same result. Something isn't right there. I would expect an array with multiple entries when multiple orders are cancelled, and with one entry when only one order is cancelled, it is always just one object, and never an array.

[carlosmiei]

Hello @vitaly-t,

Thanks for reporting it we will take a look and get back to you

[vitaly-t]

Also, worth noting, the naming for the type should be FuturesCancelOpenOrder for a single-cancel order, or FuturesCancelAllOpenOrders, if it represents a set (it currently does not).

In all, I would expect futuresCancelAll to return Promise<FuturesCancelOpenOrder[]>

[carlosmiei]

@vitaly-t Ok so in this case,as you noted the exchange returns just this object without specifying which orders were canceled

{
	"code": 200, 
	"msg": "The operation of cancel all open order is done."
}

So we can't return an array there, just a generic str:any dictionary like Promise<{ [key: string]: any }

Regarding the name, I agree that it could be an option, but since a different syntax was adopted in the past, we can't change it now because it would introduce a breaking change.

Right now we have:
futuresCancel - cancels a single order
futuresCancelAll - cancels all open orders
futuresCancelMultipleOrders - cancels multiple orders by id

[carlosmiei]

@vitaly-t We have released a new version (1.0.10) that fixes the return type, please let us know if anything.

[vitaly-t]

It looks good, cheers!