Makefile: Fix 'make update bin/eclair.jar'

[jtimon]

It is currently not working.

To reproduce:

make docker-build ; docker run lnintegration bash -c "make update-eclair bin/eclair.jar"

Error:

Downloading from central: https://repo.maven.apache.org/maven2/org/scala-lang/scala-library/2.11.6/scala-library-2.11.6.jar
Downloaded from central: https://repo.maven.apache.org/maven2/org/scala-lang/scala-library/2.11.6/scala-library-2.11.6.jar (5.6 MB at 16 MB/s)
[ERROR] /root/lightning-integration/src/eclair/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala:19: error: object CRC32C is not a member of package java.util.zip
[ERROR] import java.util.zip.CRC32C
[ERROR]        ^
[ERROR] /root/lightning-integration/src/eclair/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala:1059: error: not found: type CRC32C
[ERROR]     val checksum = new CRC32C()
[ERROR]                        ^
[ERROR] two errors found
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for eclair_2.11 0.3.2-SNAPSHOT:
[INFO] 
[INFO] eclair_2.11 ........................................ SUCCESS [ 12.144 s]
[INFO] eclair-core_2.11 ................................... FAILURE [ 58.491 s]
[INFO] eclair-node ........................................ SKIPPED
[INFO] eclair-node-gui .................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:10 min
[INFO] Finished at: 2019-08-29T15:23:10Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal net.alchim31.maven:scala-maven-plugin:3.4.2:compile (scalac) on project eclair-core_2.11: wrap: org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :eclair-core_2.11
cp src/eclair/eclair-node/target/eclair-node-*-d67ba48.jar bin/eclair.jar
cp: cannot stat 'src/eclair/eclair-node/target/eclair-node-*-d67ba48.jar': No such file or directory
make: *** [bin/eclair.jar] Error 1
Makefile:40: recipe for target 'bin/eclair.jar' failed

[sstone]

It's very likely because you're not building with OpenJDK 11, which is our recommended JDK.

[jtimon]

Yes, that's probably it, the dockerfile is using version 8, not 11:

https://github.com/cdecker/lightning-integration/blob/master/Dockerfile#L35
https://github.com/cdecker/lightning-integration/blob/master/Dockerfile#L62
https://github.com/cdecker/lightning-integration/blob/master/Dockerfile#L79

Some blogs tell you to sudo add-apt-repository ppa:linuxuprising/java to get version 11 on ubuntu bionic, do you think it's a good idea?

In any case, any suggestions to improve the eclair part of the dockerfile are more than welcomed.

[sstone]

You could just install openjdk-11-jdk from ubuntu's standard repos. People used specific ppas to install Oracle's JDK (which used to be significantly different from OpenJDK) because of licensing issues, from JDK 11 on both JDKs are almost identical so you may as well use OpenJDK.

[jtimon]

Thanks a lot, #79 seems to fix it.